fix(widget): apply native window fixes after frontend ready - #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The Linux frame-sync workaround ran once from Wails
OnStartup. Wails invokes that callback concurrently with native window setup, before the GTK window is realized.gtk_widget_get_window()could therefore return NULL; the idle callback removed itself and the workaround never took effect. Under Mutter/X11 the widget could then remain alive while GTK stopped drawing and processing visible interaction after a frame-sync acknowledgement stalled.Fix
OnStartupsetup and repeat it idempotently fromWidgetBridge.Ready().Verification
go test -tags webkit2_41 -timeout 60s ./desktop/go vet -tags webkit2_41 ./desktop/npm test -- --run(177 files, 2322 tests)GOOS=windows CGO_ENABLED=0 go test -c ...