Skip to content

fix: replace CGI.parse, removed in Ruby 4.0, with URI.decode_www_form #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gagalago wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: replace CGI.parse, removed in Ruby 4.0, with URI.decode_www_form #793

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/unit/authentication_endpoints_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,10 +477,10 @@ def test_par_authorization_url_builds_correctly
url = @client_secret_instance.send(:par_authorization_url, request_uri)

parsed = URI.parse(url.to_s)
params = CGI.parse(parsed.query)
params = URI.decode_www_form(parsed.query).to_h

assert_equal @client_id, params["client_id"].first
assert_equal request_uri, params["request_uri"].first
assert_equal @client_id, params["client_id"]
assert_equal request_uri, params["request_uri"]
assert_equal "/authorize", parsed.path
assert_equal @domain, parsed.host
end
Expand Down