fix(dev): default the command to headless mode - #2236
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Small, focused fix. The three changes hang together: --mode enum drops tui, the always-throwing flags.mode === "tui" guard is removed, and the default flips to headless. InputValidationError is still used elsewhere in the file, so no orphaned imports. Nothing else in the repo references mode: "tui" besides a leftover in the test harness's helper type (src/handlers/project/dev/index.test.ts:169 still declares mode?: "browser" | "headless" | "tui"). That's harmless — no test actually passes "tui" — so not a blocker, but worth tightening in a follow-up.
One thing worth double-checking before merging: switching the default from browser to headless is a user-visible behavior change. The PR description notes the browser-open behavior is going away by default, which seems intentional given the help text update. Just make sure any docs/tutorials/release notes that show agentcore project dev opening the Agent Inspector are updated accordingly (I didn't find any in-repo, but external docs may exist).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2236 +/- ##
=========================================
Coverage 96.98% 96.98%
=========================================
Files 564 564
Lines 39226 39221 -5
=========================================
- Hits 38042 38040 -2
+ Misses 1184 1181 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Problem
Solution
Verification
before this would open the browser.