fix: show inputs on ENTER and add selected state styling - #2238
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Nice cleanup. The PR does three cohesive things:
FormTextArea: replaces the top-only divider with a rounded box around the editable content and colors it withtheme.colors.focuswhen focused. Reads clearly.PromptStep: drops the border box around the char counter — good simplification.ModelStep(project create) andMemoryStepbyo (harness create/update): hides the dependent text field(s) until the user confirms the radio choice withenter, and shows a "selected" indicator on the radio while editing. This matches the existingToolsSteppattern, and the new update test that verifies the current byo ARN isn't revealed until enter is a nice privacy touch.
I checked the ScrollView interaction in ModelStep — keepFocusedFieldVisible re-runs when focusedField changes, and onItemHeightChange will fire when fields mount/unmount, so hiding the fields until enter doesn't break scrolling.
Tests exercise the real components end-to-end via renderScreen — no additional mocking introduced. No new user-facing feature that would need telemetry, so nothing missing there either.
Looks good to merge.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2238 +/- ##
=========================================
Coverage 96.98% 96.99%
=========================================
Files 564 564
Lines 39221 39216 -5
=========================================
- Hits 38040 38039 -1
+ Misses 1181 1177 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
Two consistency fixes in the TUI to bring screens in harness create/update and project create inline with the rest of the codebase.
harness -> create/update -> memory: Input field previously appeared immediately on hover. And no select state was present. With update, user must click enter for input to appear. Selection now has styling, and on return/esc value in input field is persisted.harness -> create/update -> prompt: usesFormTextAreacomponent, which is a multi-line version ofFormTextInput. However, the are component was missing the styling applied to the form input component. This PR aligns the styling between the two for consistencyBefore
Screen.Recording.2026-09-04.at.4.43.46.PM.mov
After
Screen.Recording.2026-09-04.at.4.44.48.PM.mov
Type of Change
Testing
How have you tested the change?
bun run test(x pass, 0 fail)npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.