-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(init): add --checkout option to sam init command for specifying git branch, tag, or commit #9124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MustafizSaadi
wants to merge
10
commits into
aws:develop
Choose a base branch
from
MustafizSaadi:3555-add-checkout-flag-for-sam-init-command-for-noncookiecutter-projects
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(init): add --checkout option to sam init command for specifying git branch, tag, or commit #9124
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4b9e72a
feat(init): add --checkout option to sam init command for specifying …
MustafizSaadi 6acc848
feat(init): refactor checkout parameter in cli and do_cli methods
MustafizSaadi b30ba7a
Merge branch 'develop' into 3555-add-checkout-flag-for-sam-init-command
MustafizSaadi ff0236c
fix: add --checkout validation and integration tests
roger-zhangg d1319d7
Merge branch 'develop' into 3555-add-checkout-flag-for-sam-init-command
roger-zhangg be2ae19
ci: retrigger CI checks
roger-zhangg 03dcae6
feat: add --checkout flag to generate_non_cookiecutter_project for br…
MustafizSaadi 1a5f90f
feat: update integration tests for --checkout flag in init command fo…
MustafizSaadi 0e2f8d9
Merge branch 'develop' into 3555-add-checkout-flag-for-sam-init-comma…
MustafizSaadi 5efacc6
feat: Resolve black check issues
MustafizSaadi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[GENERAL] The
checkoutparameter threaded throughdo_interactive→generate_application→_generate_from_location/_generate_from_use_caseis unreachable with a non-Nonevalue from the CLI.--checkoutdeclaresrequired_param_lists=[["location"]], and indo_cliany truthylocationtakes theif location or zip_bool or image_boolbranch, sodo_interactiveis only ever called withcheckout=None.The one way to reach it is a
samconfig.tomlentry, sinceClickMutex.handle_parse_resultreturns early whenself.name not in optsand config values arrive viactx.default_maprather thanopts— bypassing the--locationrequirement entirely. In that case_generate_from_use_caseoverwriteslocationwithtemplates.location_from_app_template(...)(a local cache path), and the checkout is silently dropped by cookiecutter. Either drop the interactive plumbing, or make the interactive path actually honor/rejectcheckoutrather than silently ignoring it.