Fix missing SSH key pair for VDI launches - #191
Open
Ramya0405 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where newly launched VDIs may not be assigned the cluster's configured SSH key pair.
Root cause
When
session.server.key_pair_nameis missing,complete_create_session_request()did not populate it with the cluster's configured SSH key pair. As a result, the EC2 launch parameters could omitKeyName.Changes
session.server.key_pair_namefromcluster.network.ssh_key_pairwhen it is missing.Testing
47 passedintest_session_utils.py1 passedgit diff --check: passedFixes #187