fix: bind execution RPC endpoints to localhost - #1167
Open
pekkahcut wants to merge 1 commit into
Open
Conversation
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking through the default docker compose setup, I noticed that
the execution RPC, websocket and metrics ports are exposed on all host
interfaces.
I changed these bindings to 127.0.0.1 so they are only reachable from
the local host by default.
The container ports stay the same, and I left the P2P ports unchanged
since those still need to be reachable for node communication.
This keeps the default setup a bit safer without changing how the
execution service works inside the container.