Skip to content

Show achievements when live milestones are met - #125

Merged
bashmohandes merged 3 commits into
masterfrom
feature/live-achievement-notifications
Sep 3, 2026
Merged

Show achievements when live milestones are met#125
bashmohandes merged 3 commits into
masterfrom
feature/live-achievement-notifications

Conversation

@bashmohandes

Copy link
Copy Markdown
Owner

Summary

  • add rate-limited, server-validated achievement checkpoints for irrevocable in-game milestones
  • notify Tetris and local Battle Tanks achievements as their conditions are met while preserving end-result fallback and deduplication
  • keep live toasts clear of mobile controls and document/test the trust boundary

Verification

  • node --test (331 passed)
  • full package syntax-check command run directly with node --check (passed)
  • node --test tests/achievements.test.js tests/shared-game-assets.test.js (26 passed after final edits)
  • git diff --check
  • browser verification at desktop and 390x844 viewports

Note: npm itself is broken in this environment because its global npm-cli.js is missing, so the package scripts were executed directly with Node.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-03T23:31:53.436037Z ab9307f PR opened
🔒 Security Review Completed 2026-09-03T23:32:59.239873Z ab9307f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ab9307fd81

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread arcade.js
@bashmohandes
bashmohandes merged commit 647cf2d into master Sep 3, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant