feat(runfiles): add CreateOrRaise API - #4028
Queued
rickeylev wants to merge 2 commits into
Queued
Conversation
Currently, Runfiles.Create returns None when runfiles environment variables ($RUNFILES_MANIFEST_FILE and $RUNFILES_DIR) are unset or empty, requiring callers to perform repetitive None checks. This adds Runfiles.CreateOrRaise and module-level CreateOrRaise, which return the instantiated runfiles object or raise a RuntimeError if runfiles cannot be found.
dougthor42
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Runfiles.Create returns None when runfiles environment
variables ($RUNFILES_MANIFEST_FILE and $RUNFILES_DIR) are unset or
empty, requiring callers to write repetitive None checks and handle
missing runfiles manually.
This adds Runfiles.CreateOrRaise and module-level CreateOrRaise, which
return the initialized Runfiles instance or raise a RuntimeError if
runfiles cannot be found.