Skip to content

docs: retroactive spec 033 for work-on-goal find-or-create - #94

Merged
bborbe merged 1 commit into
masterfrom
docs/spec-033-work-on-goal-find-or-create
Aug 19, 2026
Merged

docs: retroactive spec 033 for work-on-goal find-or-create#94
bborbe merged 1 commit into
masterfrom
docs/spec-033-work-on-goal-find-or-create

Conversation

@bborbe

@bborbe bborbe commented Aug 19, 2026

Copy link
Copy Markdown
Owner

Summary

Adds the spec that should have preceded PR #93 (shipped as v0.112.0): /vault-cli:work-on-goal auto-creating a missing goal.

Specs-only change — pipeline-only, so no CHANGELOG bullet, no version bump, no tag.

Why retroactive

The change was hand-authored directly instead of routed through the spec → prompt → dark-factory flow that this repo's .dark-factory.yaml (autoGeneratePrompts: true) mandates, and the first edits happened on the master working tree rather than a feature worktree. Both were caught mid-flight and corrected before merge (worktree retrofitted, local /coding:pr-review run) — but the spec was missing entirely.

The sibling change this one mirrors, spec 016-work-on-task-move-create-gate-to-slash-command, did get a spec. This restores the trail so the pattern has documentation on both routes.

Contents

  • Summary / Problem / Goal / Non-goals / Acceptance criteria in the repo's standard spec shape
  • A Process deviation section recording the gap deliberately rather than omitting it
  • A Shipped section pinning the PR, merge commit, release tag, files, and verification evidence

Documents the v0.112.0 change that shipped in PR #93 before a spec was
written. Records the design (mirrors spec 016's agent-emits-verdict /
command-owns-create split), the acceptance criteria, and the process
deviation: hand-authored on master instead of routed through the
dark-factory spec flow this repo mandates.

@ben-s-pull-request-reviewer ben-s-pull-request-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mechanical funnel found one SHOULD issue — no ## Unreleased bullet — but that is expected here: this PR is the retroactive spec for v0.112.0 which already shipped. The CHANGELOG correctly shows the released version, not ## Unreleased. This is not a defect.

No step-4b judgment rules are relevant to a specs/completed/ file with no source code change.

Verification summary:

  • Spec accurately records the shipped behavior — confirmed by cross-referencing agents/work-on-goal-assistant.md and commands/work-on-goal.md
  • Version alignment across all four mandatory locations: plugin.json, marketplace.json metadata, marketplace.json plugins[0], and CHANGELOG.md all read 0.112.0
  • No ## Unreleased is expected and correct — the release already happened
  • Single file changed: specs/completed/033-work-on-goal-find-or-create.md
  • Process deviation is self-documented in the spec's own § Process deviation

Must Fix: None.

Should Fix: None.

Nice to Have: None.

Notes:

  • This is a docs-only retroactive spec. The implementation shipped in PR #93 / v0.112.0. No new source code is being reviewed — only the spec that documents what already shipped.
  • The spec accurately captures the two-blocker architecture (work-on-goal-assistant emits structured not_found: verdict and stops; commands/work-on-goal.md Phase 4 owns creation via Skill: vault-cli:create-goal), the allowed-tools expansion to [Task, AskUserQuestion, Skill, Bash(vault-cli *)], the MODE=non_interactive guard, and the Jira-key deduplication via jira: frontmatter.
  • The process deviation is properly recorded rather than hidden — good practice for a retroactive spec.

{
  "verdict": "approve",
  "summary": "Docs-only retroactive spec for v0.112.0 work-on-goal find-or-create. Spec accurately reflects the shipped implementation across work-on-goal-assistant.md and commands/work-on-goal.md. Version alignment verified across all four mandatory files. No source code changes.",
  "comments": [],
  "concerns_addressed": [
    "tests: Spec is retroactive — documents shipped PR #93 (v0.112.0). No new implementation to test; spec accurately reflects shipped behavior including not_found verdict structure, Skill invocation in Phase 4, Jira-key frontmatter deduplication, and non_interactive MODE guard."
  ]
}

@bborbe
bborbe merged commit 67eb08d into master Aug 19, 2026
1 check failed
@bborbe
bborbe deleted the docs/spec-033-work-on-goal-find-or-create branch August 19, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant