docs: retroactive spec 033 for work-on-goal find-or-create - #94
Merged
Conversation
Documents the v0.112.0 change that shipped in PR #93 before a spec was written. Records the design (mirrors spec 016's agent-emits-verdict / command-owns-create split), the acceptance criteria, and the process deviation: hand-authored on master instead of routed through the dark-factory spec flow this repo mandates.
There was a problem hiding this comment.
The mechanical funnel found one SHOULD issue — no ## Unreleased bullet — but that is expected here: this PR is the retroactive spec for v0.112.0 which already shipped. The CHANGELOG correctly shows the released version, not ## Unreleased. This is not a defect.
No step-4b judgment rules are relevant to a specs/completed/ file with no source code change.
Verification summary:
- Spec accurately records the shipped behavior — confirmed by cross-referencing
agents/work-on-goal-assistant.mdandcommands/work-on-goal.md - Version alignment across all four mandatory locations:
plugin.json,marketplace.jsonmetadata,marketplace.json plugins[0], andCHANGELOG.mdall read0.112.0✓ - No
## Unreleasedis expected and correct — the release already happened - Single file changed:
specs/completed/033-work-on-goal-find-or-create.md - Process deviation is self-documented in the spec's own § Process deviation
Must Fix: None.
Should Fix: None.
Nice to Have: None.
Notes:
- This is a docs-only retroactive spec. The implementation shipped in PR #93 / v0.112.0. No new source code is being reviewed — only the spec that documents what already shipped.
- The spec accurately captures the two-blocker architecture (
work-on-goal-assistantemits structurednot_found:verdict and stops;commands/work-on-goal.mdPhase 4 owns creation viaSkill: vault-cli:create-goal), theallowed-toolsexpansion to[Task, AskUserQuestion, Skill, Bash(vault-cli *)], theMODE=non_interactiveguard, and the Jira-key deduplication viajira:frontmatter. - The process deviation is properly recorded rather than hidden — good practice for a retroactive spec.
{
"verdict": "approve",
"summary": "Docs-only retroactive spec for v0.112.0 work-on-goal find-or-create. Spec accurately reflects the shipped implementation across work-on-goal-assistant.md and commands/work-on-goal.md. Version alignment verified across all four mandatory files. No source code changes.",
"comments": [],
"concerns_addressed": [
"tests: Spec is retroactive — documents shipped PR #93 (v0.112.0). No new implementation to test; spec accurately reflects shipped behavior including not_found verdict structure, Skill invocation in Phase 4, Jira-key frontmatter deduplication, and non_interactive MODE guard."
]
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the spec that should have preceded PR #93 (shipped as v0.112.0):
/vault-cli:work-on-goalauto-creating a missing goal.Specs-only change — pipeline-only, so no CHANGELOG bullet, no version bump, no tag.
Why retroactive
The change was hand-authored directly instead of routed through the spec → prompt → dark-factory flow that this repo's
.dark-factory.yaml(autoGeneratePrompts: true) mandates, and the first edits happened on themasterworking tree rather than a feature worktree. Both were caught mid-flight and corrected before merge (worktree retrofitted, local/coding:pr-reviewrun) — but the spec was missing entirely.The sibling change this one mirrors, spec
016-work-on-task-move-create-gate-to-slash-command, did get a spec. This restores the trail so the pattern has documentation on both routes.Contents