PSP-11828 : Notification Reminders: Acquisition File (Expropriation History event) - Appraisal Effective date - #5403
Open
eddherrera wants to merge 4 commits into
Open
PSP-11828 : Notification Reminders: Acquisition File (Expropriation History event) - Appraisal Effective date #5403eddherrera wants to merge 4 commits into
eddherrera wants to merge 4 commits into
Conversation
…istory event) - Appraisal Effective date
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5403 |
3 similar comments
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5403 |
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5403 |
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5403 |
|
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5403 |
1 similar comment
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5403 |
areyeslo
reviewed
Sep 3, 2026
areyeslo
requested changes
Sep 3, 2026
areyeslo
left a comment
areyeslo
left a comment
Collaborator
There was a problem hiding this comment.
nit: Enum members should ideally be descriptive: ADVPMTSRVDDT would become AdvancePaymentServedDate for instance.
areyeslo
self-requested a review
September 4, 2026 20:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.