Skip to content

Use JsonPointer syntax - #348

Merged
jpraet merged 26 commits into
mainfrom
feature/#344-use-json-pointer-syntax
Aug 13, 2026
Merged

Use JsonPointer syntax#348
jpraet merged 26 commits into
mainfrom
feature/#344-use-json-pointer-syntax

Conversation

@usku01

@usku01 usku01 commented Jun 19, 2026 •
edited by jpraet
Loading

Copy link
Copy Markdown
Collaborator

Fixes #344

@usku01
usku01 requested a review from a team June 19, 2026 08:40
@jpraet

jpraet commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

JsonPointer syntax only needs to be used for InEnum.BODY.
A query, path or header param with name "foo.bar" should be accepted.

@usku01

usku01 commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

JsonPointer syntax only needs to be used for InEnum.BODY. A query, path or header param with name "foo.bar" should be accepted.

What if we have a query parameter which would be a list, shouldn't we add the index in the name? And what I mean by that is of the query param is named 'parameter.id', if we have an issue with the second member of the list, then the name in the issue should be 'parameter.id/1'?

@usku01

usku01 commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

JsonPointer syntax only needs to be used for InEnum.BODY. A query, path or header param with name "foo.bar" should be accepted.

What if we have a query parameter which would be a list, shouldn't we add the index in the name? And what I mean by that is of the query param is named 'parameter.id', if we have an issue with the second member of the list, then the name in the issue should be 'parameter.id/1'?

I have applied changes to the implementation to allow "." in name

@jpraet

jpraet commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

JsonPointer syntax only needs to be used for InEnum.BODY. A query, path or header param with name "foo.bar" should be accepted.

What if we have a query parameter which would be a list, shouldn't we add the index in the name? And what I mean by that is of the query param is named 'parameter.id', if we have an issue with the second member of the list, then the name in the issue should be 'parameter.id/1'?

I think it's fine to keep using parameter.id[1] there.
JSON Pointer is specifically for pointing to a specific value within a JSON object.

@usku01
usku01 requested a review from jpraet June 26, 2026 09:15
@sonarqubecloud

sonarqubecloud Bot commented Jun 26, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jpraet
jpraet reviewed Jul 29, 2026
View reviewed changes
Comment thread ...st-problem-jakarta-ee-it/src/main/java/io/github/belgif/rest/problem/LocalDateConverter.java Outdated
Comment thread .../src/main/java/io/github/belgif/rest/problem/ee/server/internal/ConstraintViolationUtil.java Outdated
Comment thread ...c/test/java/io/github/belgif/rest/problem/ee/server/jaxrs/BadRequestExceptionMapperTest.java
Comment thread ...src/test/java/io/github/belgif/rest/problem/ee/server/jaxrs/NotFoundExceptionMapperTest.java
Comment thread ...em-validator/src/test/java/io/github/belgif/rest/problem/validation/PeriodValidatorTest.java Outdated
Comment thread ...m-validator/src/test/java/io/github/belgif/rest/problem/validation/RequestValidatorTest.java Outdated
@usku01
usku01 requested a review from jpraet July 30, 2026 08:03
jpraet
jpraet reviewed Jul 30, 2026
View reviewed changes
Comment thread belgif-rest-problem/src/main/java/io/github/belgif/rest/problem/internal/JsonPointerUtil.java Outdated
Comment thread ...lidator/src/main/java/io/github/belgif/rest/problem/validation/AbstractRequestValidator.java Outdated
Comment thread belgif-rest-problem/src/main/java/io/github/belgif/rest/problem/api/InputValidationIssues.java Outdated
jflabatBCSS
jflabatBCSS reviewed Aug 7, 2026
View reviewed changes

@jflabatBCSS jflabatBCSS left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but they are really optional.

Comment thread .../test/java/io/github/belgif/rest/problem/ee/server/internal/ConstraintViolationUtilTest.java Outdated
Comment thread ...lidator/src/main/java/io/github/belgif/rest/problem/validation/AbstractRequestValidator.java Outdated
Comment thread belgif-rest-problem/src/main/java/io/github/belgif/rest/problem/api/InputValidationIssue.java Outdated
jpraet added 3 commits August 7, 2026 09:02
@jpraet
Merge branch 'main' into feature/#344-use-json-pointer-syntax
154c47e
@jpraet
Handle some review comments
341b74f 
* Rename to convertToJsonPointerIfNeeded
* Don't call transformName for user-provided names,
  rely on auto-covnersion instead
* Simplified JSON Pointer detection and accept "" as valid JSON Pointer
* Extract JsonPointerUtil.addIndex
@jpraet
Replace getNameFromProperties by transformName
e4576aa
@sonarqubecloud

sonarqubecloud Bot commented Aug 12, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
99.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jpraet
jpraet merged commit d5e8a1b into main Aug 13, 2026
3 checks passed
@jpraet
jpraet deleted the feature/#344-use-json-pointer-syntax branch August 13, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jflabatBCSS jflabatBCSS jflabatBCSS left review comments
@jpraet jpraet jpraet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use JSON pointer syntax in "name" field for request body input validation issues

3 participants

@usku01 @jpraet @jflabatBCSS