Use the public storage_type attribute of boost-histogram - #46
Open
davidwalter2 wants to merge 1 commit into
Open
Use the public storage_type attribute of boost-histogram#46davidwalter2 wants to merge 1 commit into
davidwalter2 wants to merge 1 commit into
Conversation
boost-histogram renamed _storage_type to storage_type; the leading underscore marked it private, so relying on it was always a bet on an implementation detail. The current version no longer provides it, and make_array_interface_view and hist_to_pyroot_boost raise AttributeError before doing any work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
boost-histogram renamed
_storage_typetostorage_type. The leadingunderscore marked it private, so reading it was always a bet on an
implementation detail, and current versions no longer provide it at all.
make_array_interface_viewandhist_to_pyroot_boosttherefore raiseAttributeErrorbefore doing any work, which makes histogram production failon the current
wmassdevrollingcontainer.Four call sites, mechanical:
_storage_type->storage_type.🤖 Generated with Claude Code
https://claude.ai/code/session_01HrsrmERvJF2Vafn7wE1B3v