Skip to content

Fix entry width rendering in editor - #626

Merged
uldisrudzitis merged 1 commit into
masterfrom
fix-entry-width-rendering
Aug 20, 2026
Merged

Fix entry width rendering in editor#626
uldisrudzitis merged 1 commit into
masterfrom
fix-entry-width-rendering

Conversation

@uldisrudzitis

@uldisrudzitis uldisrudzitis commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Corrected entry width styling to preserve provided units.
    • Retained the default pixel-based width when no custom width is specified.

@uldisrudzitis uldisrudzitis self-assigned this Aug 20, 2026
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 78ed7fb4-b75f-454c-a64b-37428ff2052b

📥 Commits

Reviewing files that changed from the base of the PR and between 26dc339 and 1317f0e.

📒 Files selected for processing (1)
  • editor/src/app/sites/sections/entries/section-entry-render.service.ts

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The entry render service now uses the raw entry.content.width value for inline width styles. The fallback width from shopSettings.group_price_item.entryWidth still appends px.

Changes

Entry Width Style

Layer / File(s) Summary
Width style generation
editor/src/app/sites/sections/entries/section-entry-render.service.ts
Explicit entry widths no longer receive an appended px suffix. The settings-based fallback remains unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 1317f

This is a narrowly scoped editor rendering change, and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the change to entry width rendering in the editor.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-entry-width-rendering

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@uldisrudzitis
uldisrudzitis merged commit 706bc0b into master Aug 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant