feat: backup app volumes before deployment - #140
Merged
Merged
Conversation
Add automatic pre-deployment backups for volumes. Backup schedules can opt in with a new backupBeforeDeployment flag and a failSilently option in the existing volume backup settings. Before a deployment is applied, opted-in schedules of the deployed app and of its directly connected apps (1 hop through app network policies, same project) run one after another. Progress and errors are written to the deployment logs. A failed backup aborts the deployment unless it is marked failSilently. The trigger hooks into deployment.service.createDeployment, so UI deploys, rollbacks, webhooks and build-watch deployments are all covered.
…ttings Replace the checkboxes for backupBeforeDeployment and failSilently with switch toggles and move their descriptions into question mark tooltips.
…orm label component
biersoeckli
marked this pull request as ready for review
September 24, 2026 15:21
biersoeckli
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds automatic volume backups that run before a deployment is applied.
Behavior
VolumeBackup:backupBeforeDeployment(defaultfalse) — opt in.failSilently(defaultfalse) — continue the deployment when the backup fails; otherwise the deployment is aborted.deployment.service.createDeployment, covering UI deploys, rollbacks, webhooks and build-watch deployments.Implementation
20260924140414_add_pre_deployment_backupadds the two columns.getDirectlyConnectedAppIdslives innetwork-policy.service.ts.runBackupsBeforeDeploymentlives involume-backup.service.ts;backup.service.runBackupForScheduleencapsulates DB-dump vs volume-archive selection.Testing
yarn lintclean.tsc -p tsconfig.server.jsonexit 0.