Fix mobile terminal scrolling and session tool access - #165
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The previous touch bridge dispatched a synthetic
WheelEvent. xterm uses native viewport scrolling for normal-buffer history, but browser default scrolling is not performed for script-dispatched wheel events. The event therefore existed and the unit test passed, while the terminal viewport did not move on a phone.The original phone dock prioritized global destinations even though active-session SFTP, commands, and metrics are the frequent terminal-adjacent actions. Those tools required opening More, choosing a generic Tools action, and then selecting another tab. The revised dock puts the session workflow in the persistent thumb zone while retaining every global destination in More.
Validation
viewportYmoved away from the bottomgit diff --checkpassed