Skip to content

Fix mobile terminal scrolling and session tool access - #165

Merged
bifrost0x merged 2 commits into
mainfrom
dev/mobile-terminal-touch-scroll
Aug 30, 2026
Merged

Fix mobile terminal scrolling and session tool access#165
bifrost0x merged 2 commits into
mainfrom
dev/mobile-terminal-touch-scroll

Conversation

@bifrost0x

@bifrost0x bifrost0x commented Aug 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • scroll normal xterm history directly from vertical touch gestures instead of relying on a synthetic wheel event that cannot trigger native browser scrolling
  • preserve coordinate-aware wheel forwarding for tmux, Vim, and other alternate-screen or mouse-tracking applications
  • replace the phone dock's global shortcuts with direct active-session destinations: Terminal, SFTP, Commands, Metrics, and More
  • keep Hosts, the global File Manager, the Command Library, Notes, and all secondary actions available from More
  • synchronize dock selection and disabled states with the active workspace and live SFTP/diagnostics capability
  • bump all affected asset versions so mobile browsers do not retain the old behavior

Root cause

The previous touch bridge dispatched a synthetic WheelEvent. xterm uses native viewport scrolling for normal-buffer history, but browser default scrolling is not performed for script-dispatched wheel events. The event therefore existed and the unit test passed, while the terminal viewport did not move on a phone.

The original phone dock prioritized global destinations even though active-session SFTP, commands, and metrics are the frequent terminal-adjacent actions. Those tools required opening More, choosing a generic Tools action, and then selecting another tab. The revised dock puts the session workflow in the persistent thumb zone while retaining every global destination in More.

Validation

  • 34 JavaScript test files passed
  • JavaScript lint passed
  • 59 focused Python UI and asset-version tests passed
  • the 360 px Playwright workspace scenario passed after filling real xterm scrollback, performing a touch gesture, and verifying that viewportY moved away from the bottom
  • the same browser scenario directly opened SFTP, Metrics, Commands, Terminal, and More from the revised dock and verified that global destinations remain available
  • visual QA passed at 360 x 640 with the active session tool clearly highlighted in the persistent bottom dock
  • git diff --check passed

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-30T12:51:13.626300Z df9f14a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@bifrost0x bifrost0x changed the title Fix touch scrolling in mobile terminal history Fix mobile terminal scrolling and session tool access Aug 30, 2026
@bifrost0x
bifrost0x merged commit d58ab28 into main Aug 30, 2026
16 of 17 checks passed
@bifrost0x
bifrost0x deleted the dev/mobile-terminal-touch-scroll branch August 30, 2026 13:20
@github-project-automation github-project-automation Bot moved this from Backlog to Done in WebSSH Roadmap Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant