Skip to content

Stabilize mobile Settings Center E2E readiness - #172

Merged
bifrost0x merged 1 commit into
mainfrom
dev/fix-mobile-settings-readiness
Aug 31, 2026
Merged

Stabilize mobile Settings Center E2E readiness#172
bifrost0x merged 1 commit into
mainfrom
dev/fix-mobile-settings-readiness

Conversation

@bifrost0x

Copy link
Copy Markdown
Owner

Summary

  • wait for the Preferences panel to be activated by the Settings Center navigation before measuring mobile layout
  • avoid treating unstyled, pre-initialization markup as the rendered page
  • keep production UI and layout behavior unchanged

Root cause

The failed post-merge run measured document width while the Settings Center CSS and JavaScript were still loading. Visibility checks could pass before the hidden CSS rule was available, so the test observed the intrinsic width of inactive administration markup.

Verification

  • affected mobile test repeated 10 times: 10 passed
  • affected test with a simulated 500 ms stylesheet delay: passed
  • complete account-menu.spec.js: 3 passed

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T11:06:41.974121Z 89418b6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@bifrost0x
bifrost0x merged commit 993f32c into main Aug 31, 2026
21 checks passed
@bifrost0x
bifrost0x deleted the dev/fix-mobile-settings-readiness branch August 31, 2026 11:09
@github-project-automation github-project-automation Bot moved this from Backlog to Done in WebSSH Roadmap Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant