Skip to content

fix(security): retry queued SSH input backpressure - #176

Merged
bifrost0x merged 1 commit into
mainfrom
fix/queued-ssh-input-backpressure
Aug 31, 2026
Merged

fix(security): retry queued SSH input backpressure#176
bifrost0x merged 1 commit into
mainfrom
fix/queued-ssh-input-backpressure

Conversation

@bifrost0x

Copy link
Copy Markdown
Owner

Summary

  • retry an acknowledged single SSH input chunk when it was queued behind a large paste
  • preserve the low-latency fire-and-forget path for normal, unqueued typing
  • bump the SSH input asset cache version so deployed browsers receive the fix
  • cover renewed backpressure on the queued single-chunk path with a regression test

Context

This follows up on #175 and addresses the post-merge review finding that a keystroke queued behind a rate-limited paste could be dropped if the token bucket was still empty.

Validation

  • node --test tests/js/*.test.js — 35 passed
  • python -m pytest -q tests/test_ssh_input.py — 6 passed
  • python -m pytest -q tests/test_profile_launcher_ui.py tests/test_key_management_ui.py — 38 passed
  • git diff --check

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T12:10:01.723168Z 0b72a8f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@bifrost0x
bifrost0x merged commit b8e8be9 into main Aug 31, 2026
21 checks passed
@bifrost0x
bifrost0x deleted the fix/queued-ssh-input-backpressure branch August 31, 2026 12:14
@github-project-automation github-project-automation Bot moved this from Backlog to Done in WebSSH Roadmap Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant