Skip to content

Enable touch controls in the mobile File Manager - #177

Merged
bifrost0x merged 2 commits into
mainfrom
dev/mobile-file-manager-touch
Aug 31, 2026
Merged

Enable touch controls in the mobile File Manager#177
bifrost0x merged 2 commits into
mainfrom
dev/mobile-file-manager-touch

Conversation

@bifrost0x

Copy link
Copy Markdown
Owner

Summary

  • open folders with a single touch tap while keeping file selection and checkbox multi-select predictable
  • preserve native vertical touch scrolling, enlarge coarse-pointer targets, and keep desktop drag-and-drop unchanged
  • replace the long-press action sheet with localized, accessible buttons and prevent release events from triggering actions accidentally
  • add unit and real touch-emulation coverage for taps, scrolling, long-press actions, and pointer-specific dragging

Testing

  • node --test tests/js/*.test.js (35 test files)
  • python -m pytest -q tests/test_file_manager_source_ui.py tests/test_i18n_parity.py tests/test_webssh2_shell.py tests/test_profile_launcher_ui.py tests/test_key_management_ui.py (81 passed)
  • playwright test tests/e2e/file-workspace.spec.js tests/e2e/session-workspace.spec.js --forbid-only (22 passed)
  • ESLint on the changed JavaScript and Playwright files
  • git diff --check

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T12:51:29.323459Z 19767be PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 19767bec46

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread static/js/sftp-file-manager.js
@bifrost0x
bifrost0x merged commit cf325c7 into main Aug 31, 2026
20 of 21 checks passed
@bifrost0x
bifrost0x deleted the dev/mobile-file-manager-touch branch August 31, 2026 13:00
@github-project-automation github-project-automation Bot moved this from Backlog to Done in WebSSH Roadmap Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant