fix: adjust data modal to allow new or missing nvd data - #28
Open
l4rm4nd wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues outlined in:
nodes#27NVD has introduced new metric fields that are currently not supported by FastCVE's Pydantic models. Because the models reject unknown fields, affected CVEs can cause API response validation to fail with an HTTP 500 error.
Additionally, some newer CVE records contain configuration entries where the nodes field is missing. FastCVE currently treats this field as mandatory, which can also cause response validation to fail.
This PR makes the CVE models more tolerant of these NVD schema variations and prevents valid search results from failing due to newly introduced or optional fields.