refactor: this is a big refactor to unify and simplify the codebase. … - #59
Merged
Merged
Conversation
…This was necessary because of the use of AI without always proper oversight and unnecessary nesting. The following has changed. Moved warehouse locations, manufacturers, and categories into the internal folder. Made use of the sqlc overrides to override domain types such as Milliwatts to avoid custom mappers which means less handwritten code. Moved ksuid into uid package and let the domain layer create the uid. The handler must not know about this. Renamed reRender() to fail(). Simplify GetFiltered, GetAllFiltered, and List into one equipment.List func. Added constuctor methods BadRequest, InternalServerError, and NotFound for the httperr pkg to handle generic errors and reduce handler boilerplate. Moved VAT into its own type. Unify form.go to use Parse() and Validate() funcs. Learnings are: Refactoring takes more time than writing less code and think longer about the acutal implementation. Dont rush for features, make sure the code is reliable and as small as possible. Dont take the linter to serious for cyclomatic complexity, sometimes its okay and go on. Ai is great and combined with small changes even better. Large changes, such as these should be very rare in future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…This was necessary because of the use of AI without always proper oversight and unnecessary nesting.
The following has changed. Moved warehouse locations, manufacturers, and categories into the internal folder. Made use of the sqlc overrides to override domain types such as Milliwatts to avoid custom mappers which means less handwritten code. Moved ksuid into uid package and let the domain layer create the uid. The handler must not know about this. Renamed reRender() to fail(). Simplify GetFiltered, GetAllFiltered, and List into one equipment.List func. Added constuctor methods BadRequest, InternalServerError, and NotFound for the httperr pkg to handle generic errors and reduce handler boilerplate. Moved VAT into its own type. Unify form.go to use Parse() and Validate() funcs.
Learnings are: Refactoring takes more time than writing less code and think longer about the acutal implementation. Dont rush for features, make sure the code is reliable and as small as possible. Dont take the linter to serious for cyclomatic complexity, sometimes its okay and go on. Ai is great and combined with small changes even better. Large changes, such as these should be very rare in future.