ci: add cmake --parallel build option - #353
Conversation
Drop nproc call and inconsistent -j setting.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline and AI policy for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
| cmake "$src_dir" "${CMAKE_ARGS[@]+"${CMAKE_ARGS[@]}"}" | ||
| if ver_ge "$cmake_ver" "3.15"; then | ||
| cmake --build . -t "${BUILD_TARGETS[@]}" -- "${BUILD_ARGS[@]+"${BUILD_ARGS[@]}"}" | ||
| cmake --build . --parallel -t "${BUILD_TARGETS[@]}" -- "${BUILD_ARGS[@]+"${BUILD_ARGS[@]}"}" |
There was a problem hiding this comment.
From the CMake docs:
If
<jobs>is omitted the native build tool’s default number is used.
I don't think this change is an improvement, as it might reduce build parallelism.
There was a problem hiding this comment.
It could also lead to over-parallelism and lead to OOM?
|
Good points! Closing this PR as I did not know |
4 participants
Drop nproc call and inconsistent -j setting.