ci: bump cmake version to 4.3.4 in newdeps job - #359
Open
ryanofsky wants to merge 2 commits into
Open
Conversation
Update cmake from 4.1.1 to 4.3.4, including the corresponding sha256 hash in shell.nix. Suggested-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Reference: bitcoin-core#212 (review) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
capnproto's default branch switched to v2, so "master" is non-obvious. Suggested-by: MarcoFalke <falke.marco@gmail.com> Reference: bitcoin-core#212 (comment) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline and AI policy for information on the review process.
If your review is incorrectly listed, please copy-paste |
Contributor
|
lgtm ACK 766867f code changes seem fine, but the |
hebasto
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update cmake from 4.1.1 to 4.3.4 and add capnproto branch comment as suggested in #212 reviews