Conversation
Adds an isolated experimental package that dials a participant with noders-team/go-daml (GetLedgerApiVersion + GetLedgerEnd) so we can compare it against the existing dazl-client path without changing production WaitForHealthy or token dial wiring.
… health Wire the go-daml connectivity probe into up/start/restart so bring-up fails with LEDGER_UNREACHABLE when app-provider gRPC is not ready, instead of reporting success on container health alone.
zheli
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wire go-daml into the production readiness path: after Docker compose health succeeds,
localnet up/start/restart(unless--no-wait) probe the app-provider Ledger API (GetLedgerApiVersion+GetLedgerEnd) and fail withLEDGER_UNREACHABLEif it never becomes ready.Transaction dials still use
dazl-clientviainternal/canton/ledger; go-daml is the readiness probe only. CLI and Web UI share the sameRunUp/ start / restart paths.Changes
internal/localnet/ensureLedgerReady(polls go-daml; roleapp-provider)up,start, andrestartafter DockerWaitForHealthy+ port captureLEDGER_UNREACHABLE+ Web UI remediation paneldocs/changes-from-proposal.mdTest plan
go test ./internal/localnet/ ./internal/poc/godamlprobe/make lintnpx vitest run src/screens/remediation.test.tsupand confirm ledger probe line / failure pathChecklist
docs/changes-from-proposal.mdupdated