Add inline progress for long-running queued tasks - #35
Closed
steve-the-edwards wants to merge 3 commits into
Closed
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a0490f-1c71-77aa-9d4d-9098e1d53a7c Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0490f-1c71-77aa-9d4d-9098e1d53a7c Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0490f-1c71-77aa-9d4d-9098e1d53a7c Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long-running Gradle and benchmark commands currently hold a Model Context Protocol [MCP] tool turn until completion. Developers only see “Run Queued Task,” cannot distinguish quiet progress from a hang, and steering cancels the command.
What changed
task_statusupdates with queue position, process liveness, incremental inline output, and 30-second heartbeats.run_taskortask_statusrequests are interrupted; add explicitcancel_tasktermination.Review focus
Please focus on background task ownership, cancellation races, and persisted result/output-offset lifecycle. A regression test writes 2 MB to stderr before stdout to prove both pipes are drained concurrently.