Validate offload block request lengths - #6166
Open
WalidNejmi wants to merge 1 commit into
Open
Conversation
Check the received and declared payload sizes before processing block requests and add defensive bounds checks to block request handling. The payload offset is derived with offsetof() rather than sizeof(), since the message struct ends in a flexible-style array and sizeof() may include trailing padding. Signed-off-by: Walid Nejmi <wnejmi@bloomberg.net>
roborivers
suggested changes
Aug 26, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_resume_logicalsc_generated **quarantined**
cdb2jdbc
triggersc_latency
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
Author
|
/adhoc-test triggersc_latency cdb2jdbc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the received and declared payload sizes before processing block requests and add defensive bounds checks to block request handling.
The payload offset is derived with offsetof() rather than sizeof(), since the message struct ends in a flexible-style array and sizeof() may include trailing padding.
To help us review your pull request, please consider providing an overview of the following: