refactor(enum): model titel as free text and remove ENUM Titel - #1142
Open
lord-haffi wants to merge 1 commit into
Open
refactor(enum): model titel as free text and remove ENUM Titel#1142lord-haffi wants to merge 1 commit into
titel as free text and remove ENUM Titel#1142lord-haffi wants to merge 1 commit into
Conversation
In der Praxis kommt eine Vielzahl von Titeln vor, die sich nicht abschließend als Enum definieren lässt. `titel` wird daher auf `BO Geschaeftspartner` und `BO Person` zu einem nullable String. Closes #1085
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modelliert
titelals nullable String und entferntENUM Titelersatzlos (#1085).Das Enum kannte nur
DR,PROFundPROF_DR. In der Praxis verwenden Nutzer beliebige Titel ("Dipl.-Ing.", "M.Sc.", "M.A.", ...); ein abschließender Wertevorrat wird der Realität nicht gerecht.BO Geschaeftspartner.titel:Optional[Titel]->str | NoneBO Person.titel:Optional[Titel]->str | Nonesrc/bo4e/enum/titel.pyund der Export entfallenBreaking change: das Enum entfällt, der Feldtyp wechselt auf String. Bisherige Werte lassen sich als Freitext weiterführen (
DR-> "Dr.").Verifiziert:
pytest107 passed,ruff check src/bo4eclean,ruff format --checkclean,mypy src/bo4eclean, JSON-Schema-Generierung ok (enum/Titel.jsonentfällt,titelist in beiden BOs ein String).Closes #1085