Allow customization of the description window - #109
Merged
Conversation
sesquialtera87
marked this pull request as ready for review
January 27, 2026 14:09
Owner
|
@sesquialtera87 can you rebase? If you do I'll run the workflows and take a look at getting this merged! 🙏 |
…ions - Introduce AbstractDescWindow as an abstract base class for completion description windows. - Add descWindowFactory property to AutoCompletion to allow custom description window creation via a Function<Window, AbstractDescWindow>. - Refactor AutoCompletePopupWindow and AutoCompleteDescWindow to use the new abstraction.
sesquialtera87
force-pushed
the
desc-window
branch
from
August 18, 2026 20:19
d70a0c3 to
f1d394b
Compare
Contributor
Author
|
Hi @bobbylight, Here is a summary of the changes: Abstraction
Enhancements (
|
Owner
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual
AutoCompleteDescWindowdoes a good job, but it would be nice to have the possibility of change or tweak something of it (for example add new actions to the nav-bar or create a totally different dialog). Now it's not possible, because classAutoCompletePopupWindowcreates its own private description window without any possibility of intervention.I have created the abstract class
AbstractDescriptionWindowthat collects some common logic of the description dialog, so that, when needed, one can create a custom window and register a factory in theAutoCompletionobject.Also
addToNavBarmethods are added intoAutoCompleteDescWindowto allow insertion of actions into the nav-bar