fix(search): make CPU instances discoverable - #455
Open
theFong wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
==========================================
+ Coverage 24.67% 26.30% +1.62%
==========================================
Files 134 135 +1
Lines 18337 18627 +290
==========================================
+ Hits 4525 4899 +374
+ Misses 13335 13227 -108
- Partials 477 501 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brev search cpusorbrev search CPUinstead of silently running a GPU searchgpuandcpuas valid arguments for completionbrev searchas the default GPU searchWhy
CPU inventory already exists behind
brev search cpu, but agents have to guess that exact subcommand. Worse, misspellings and pluralization currently succeed while returning GPU results, which makes the CPU path especially difficult to discover and diagnose.Validation
go build ./...go test -race ./pkg/cmd/gpusearchgo vet ./pkg/cmd/gpusearchgolangci-lint run ./pkg/cmd/gpusearchRelated to #376. This PR intentionally limits scope to search discoverability; CPU create support remains separate.