feat: add region-aware instance search and creation - #456
Open
theFong wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--region/-rto GPU and CPU search with case-insensitive partial matching for discoverybrev createthrough--regionor--location, plus optional--sub-locationn2d-standard-2can be placed inus-west2Issue
Fixes #454
This covers the issue end to end: the request fields are populated, CPU locations are validated, default placement is visible before provisioning, and the reported
n2d-standard-2/us-west2/us-west2-apath has a mocked request-level regression test.Compatibility
brev searchandbrev createwithout placement flags retain their existing selection behaviorTYPEandTARGET_DISKas the first two columns;PROVIDERalso remains thirdGetCloudCredIDpreserves first-match behavior when no location is requestedDedupe investigation
The issue suggestion to revisit
uniqueInstanceType=truewas reviewed. This PR leaves it unchanged: validation uses the public catalogavailable_locations, and authenticated selection already matches both type and location across the returned credential entries. Changing server response cardinality without a reproduced failure would expand the scope and risk of this fix.Validation
go test -count=1 ./pkg/cmd/gpusearch ./pkg/cmd/gpucreatego test -race ./pkg/cmd/gpusearch ./pkg/cmd/gpucreatego vet ./pkg/cmd/gpusearch ./pkg/cmd/gpucreategolangci-lint run ./pkg/cmd/gpusearch ./pkg/cmd/gpucreatego build ./...go test -count=1 ./pkg/integrationNo real instance was provisioned while validating this change.
Prior work
This is a clean refresh of #393 against current
main, building on the original region-flag work by @hakhandelwal11. The older PR is intentionally left open for maintainers to handle.