fix(codex): forward output token limit - #272
Merged
Merged
Conversation
PsiACE
marked this pull request as ready for review
August 10, 2026 05:16
PsiACE
marked this pull request as draft
August 10, 2026 05:21
PsiACE
marked this pull request as ready for review
August 10, 2026 05:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Bub passes its configured
max_tokensthrough any-llm's Chat Completions interface. The Codex OAuth provider translates that request to the Responses API, but previously omitted the correspondingmax_output_tokensfield. As a result, output token limits worked with other APIs but were silently ignored for Codex OAuth requests.Summary
max_completion_tokens, ormax_tokensas a fallback, to Responsesmax_output_tokensmax_completion_tokensprecedence when both values are providedUser-facing changes
Configured output token limits now apply to Codex OAuth completions. There are no API or configuration changes.
Breaking changes
None.
Validation
uv lock --lockeduv run prek run -auv run mypy srcuv run python -m pytest --doctest-modules -q(269 passed)