fix(pjson-rs): restore pjs-demo as a buildable workspace member - #356
Merged
Conversation
github-actions
Bot
added
documentation
WASM Bundle Size Report
|
bug-ops
force-pushed
the
318-pjs-demo-unbuildable
branch
from
August 17, 2026 11:58
c73de10 to
84e108a
Compare
bug-ops
enabled auto-merge (squash)
August 17, 2026 11:58
WASM Bundle Size Report
|
bug-ops
force-pushed
the
318-pjs-demo-unbuildable
branch
from
August 17, 2026 13:18
84e108a to
65c94ca
Compare
WASM Bundle Size Report
|
bug-ops
force-pushed
the
318-pjs-demo-unbuildable
branch
from
August 17, 2026 13:28
65c94ca to
cc88982
Compare
WASM Bundle Size Report
|
bug-ops
force-pushed
the
318-pjs-demo-unbuildable
branch
2 times, most recently
from
August 17, 2026 16:20
04739d2 to
406c64d
Compare
WASM Bundle Size Report
|
crates/pjs-demo was excluded from the Cargo workspace while its manifest used full workspace = true field inheritance, which Cargo cannot resolve for a crate outside the workspace. Every documented invocation (-p pjs-demo, --manifest-path, or cd-ing into the directory) failed to parse the manifest. This regressed closed issue Restore crates/pjs-demo to [workspace] members while keeping it out of default-members, mirroring how crates/pjs-bench was restored in PR #190. This surfaced two previously-uncompiled defects, now fixed: a stale rand::Rng import (rand 0.10 moved random_range/random_bool to RngExt) in three crates/pjs-demo/src/data files, and a clippy unnecessary_sort_by lint in websocket_streaming.rs. pjs-demo declares no [features] of its own, so documented build commands must pass pjson-rs feature flags with the pjson-rs/ prefix; README.md is updated accordingly. CI's rust paths-filter now includes crates/pjs-demo/** so PRs touching only the demo crate trigger the quality/build/test/doctest/docs gates; the coverage job excludes pjs-demo to avoid an instrumented compile of its untested binaries. Closes #318
bug-ops
force-pushed
the
318-pjs-demo-unbuildable
branch
from
August 17, 2026 16:24
406c64d to
11d313d
Compare
WASM Bundle Size Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/pjs-demowas excluded from the Cargo workspace while its manifest used full{ workspace = true }field inheritance, which Cargo cannot resolve outside a workspace — every documented build invocation failed. This regressed closed issue docs: continuous-improvement.md references broken cargo run -p pjs-demo command #112, whose three proposed options were never applied.crates/pjs-demoto[workspace] members(kept out ofdefault-members), mirroring howcrates/pjs-benchwas restored in PR fix(stream): process_frame returns Processed immediately; restore pjs-bench #190. Fixes two previously-uncompiled fallout defects: a stalerand::Rngimport (rand 0.10 movedrandom_range/random_booltoRngExt) in three files, and a clippyunnecessary_sort_bylint.pjs-demodeclares no[features]of its own, documented build commands now pass pjson-rs feature flags with the requiredpjson-rs/prefix (README.mdupdated).rustpaths-filter now includescrates/pjs-demo/**so PRs touching only the demo crate trigger quality/build/test/doctest/docs gates; the coverage job excludespjs-demoto skip an instrumented compile of its untested binaries (already ignored incodecov.yml, so no coverage-check impact either way).Closes #318
Test plan
cargo +nightly fmt --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo nextest run --workspace --all-features --lib --bins(961 passed)cargo test --workspace --doc --all-featurescargo build -p pjs-demo --bin interactive-demo-server --bin simple-demo-server --bin websocket-streaming-servercargo clean -p pjs-demo)cargo metadataworkspace_default_membersunchanged (still onlypjs-core/pjs-domain/pjs-wasm)cargo deny checkclean against new lock entriesactionlint/yamllint(project'sfytool panics on this file with a pre-existing, unrelated parser bug reproduced on the pre-edit file too)