fix(domain): make GatStreamingOrchestrator::process_concurrent_streams actually concurrent - #396
Merged
Merged
Conversation
github-actions
Bot
added
documentation
bug-ops
enabled auto-merge (squash)
August 17, 2026 21:18
WASM Bundle Size Report
|
…s actually concurrent process_concurrent_streams was documented and named as processing streams concurrently via GAT futures, but awaited them one at a time in a sequential for loop. stream_with_priority only borrows &self, so nothing prevented real concurrency; it now uses futures::future::try_join_all to drive every stream's future together, still bounded by max_concurrent_streams. futures is promoted from an optional, http-server-gated dependency to a required one, since this domain-layer module compiles unconditionally and must not depend on an HTTP-transport feature flag. Documents that StreamingStats::processing_time now approximates the whole batch's elapsed time rather than an individual stream's share of it when driven concurrently, and adds a regression test asserting real overlap in wall-clock time across streams. Closes #393
bug-ops
force-pushed
the
fix/393-gat-orchestrator-concurrency
branch
from
August 17, 2026 21:22
230dc91 to
ee836dd
Compare
WASM Bundle Size Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process_concurrent_streams(crates/pjs-core/src/domain/services/gat_orchestrator.rs) was documented and named as concurrent but awaited each stream one at a time in a sequentialforloop; it now drives all streams viafutures::future::try_join_all, still bounded bymax_concurrent_streams.futuresis promoted from an optional,http-server-gated dependency to a required one, since this domain-layer module compiles unconditionally and must not depend on an HTTP-transport feature flag.StreamingStats::processing_timenow approximates the whole batch's elapsed time rather than an individual stream's share of it when driven concurrently.Closes #393
Test plan
cargo +nightly fmt --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo nextest run --workspace --all-features --lib --bins(1006/1006)cargo check -p pjson-rs --no-default-features --features simd-auto(confirmsfuturesis no longer feature-gated)RUSTFLAGS="-D warnings" RUSTDOCFLAGS="--deny rustdoc::broken_intra_doc_links" cargo doc --no-deps --workspace