v1.0.12 - #44
Conversation
updateCodeInJson guarded every match with `'code' in obj`, so a script reference carrying only `location` (no pre-existing `code` key) was skipped entirely and the encoding logic below it never ran. The documented default — absent encoding means B64 — therefore only applied to references that already had a `code` field written into them at some earlier point. Dropping the guard lets the `code` key be created when it is missing. Encoding handling is unchanged: absent/B64 writes Base64, NAT writes the native source, and any other value (e.g. REF) is still left untouched, so REF references gain no `code` key. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
fix(csx): embed CSX into references that only declare a location
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR adjusts how CSX references in JSON are updated so that entries matching the location have their Sequence diagram for updated CSX reference handling in updateCodeInJsonsequenceDiagram
participant Caller
participant updateCodeInJson
participant JsonEntry
Caller->>updateCodeInJson: updateCodeInJson(jsonPath, csxLocation, base64Code, nativeCode)
updateCodeInJson->>JsonEntry: iterate and check obj.location === csxLocation
alt location matches
JsonEntry-->updateCodeInJson: [obj.location === csxLocation]
updateCodeInJson->>JsonEntry: create_or_update code based on encoding
else location does not match
JsonEntry-->updateCodeInJson: [no action]
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary by Sourcery
Bug Fixes:
codeproperty are correctly updated when their location matches.