HOLD — do not ready: docs(rules) change refuted on home, gate and budget; see CLOUD-1533's repair note - #885
HOLD — do not ready: docs(rules) change refuted on home, gate and budget; see CLOUD-1533's repair note#885wenzowski wants to merge 1 commit into
Conversation
…d row four's write direction `.claude/rules/scanning.md` routed four question classes to four instruments and left two failures unnamed, both measured on one session (CLOUD-1533). Row five: a pointer confirmed in code is not a behaviour confirmed in the store. A row was filed on a correctly cited mechanism and stated the store behaviour it implied; a census over the store found zero entries of that origin in 9,674. The instrument is a count over the live instance, taken before the sentence is written, and the row names a capability rather than a product for row one's reason. Row four's write direction: a finding leaves the session in the turn it is found, filed or fixed, before it reaches a sentence to a human. Six defects and a root-cause analysis were carried in chat until a human asked what would survive the archive. `scanner_taxonomy.rs` pins the new row and iterates it as a capability row; the declared mutation rewrites the question so the prose assertion goes red. Refs: CLOUD-1533
|
❌ The last analysis has failed. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe scanner taxonomy adds a fifth question to determine whether pointer behavior is live or only present in code. The question uses a census over the store or session before the sentence is written. Capability-row validation now includes this question. The scanning guidance documents the row-five rule and clarifies the write direction for row four findings. Merge Risk: ⚪ Minimal · up to This change adds guidance and taxonomy coverage requiring a live store or session census before claiming pointer behavior is active. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
wenzowski
changed the title
2 participants
DO-NOT-CLOSE
Hold, 2026-09-06. This PR is not to be readied. CLOUD-1533's repair note records why: the change writes doctrine into a one-harness directory (CLOUD-1152), its test asserts presence rather than behaviour (rule 2), and the surface it grows has no token budget (CLOUD-50 counts
AGENTS.mdonly).mise run landwas stopped by hand before readying, so no CI ran on it.The two findings the change carries stand and are recorded on CLOUD-1533; what is withdrawn is the delivery. The PR stays a draft as the record of what was built, until CLOUD-1152 decides where doctrine lives and CLOUD-1470 supplies the gate-fired delivery.
Original description follows.
.claude/rules/scanning.mdgains a fifth taxonomy row and a section under row four.crates/batten/tests/it/scanner_taxonomy.rspins the new row inINSTRUMENTS, iterates it as a capability row, and declares the mutationrow-five-question-dropped.🤖 Generated with Claude Code
https://claude.ai/code/session_01Goor5aNugW4qgMassn32TG