-
Notifications
You must be signed in to change notification settings - Fork 0
feat(saas-api): X-CacheKit-Fresh-For remaining-freshness response header (LAB-557) #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
27Bslash6
wants to merge
6
commits into
main
Choose a base branch
from
lab-557-fresh-for-spec
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+64
−2
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2bc48bc
feat(saas-api): X-CacheKit-Fresh-For remaining-freshness response hea…
27Bslash6 b95674c
spec(saas-api): fresh_for is a hard local service bound, not just a f…
27Bslash6 baf1ad9
spec(saas-api): close residual serve-past-evict_at paths found by pan…
27Bslash6 8c407f9
Merge remote-tracking branch 'origin/main' into agent/winston/640ec0db
27Bslash6 0d0e172
spec(saas-api): second panel round — drop false edge-coherence figure…
27Bslash6 04ce9fd
spec(saas-api): revocation bound includes in-flight transit and clock…
27Bslash6 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Include serving-tier coherence windows in the revocation bound.
Line 108 permits composed serving tiers to compound coherence windows when a tier re-stamps a value. A client can receive an already-cached response from such a tier after the origin
DELETE, then backfill it for the emitted local bound. This response was not in flight when the deletion occurred.Line 119 includes only the local bound, in-flight transit, and clock or suspend error. Add the applicable serving-path coherence-window sum. Otherwise the TTL guidance for security-sensitive caches can understate revocation exposure.
Proposed wording
📝 Committable suggestion
🤖 Prompt for AI Agents