Skip to content

ci: drop the -- separator when forwarding args through pnpm run #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kraenhansen merged 1 commit into from
Aug 9, 2026
Merged

ci: drop the -- separator when forwarding args through pnpm run #388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ jobs:
- name: Run tests (iOS)
run: pnpm run test:ios:allTests
# TODO: Enable release mode when it works
# run: pnpm run test:ios:allTests -- --mode Release
# run: pnpm run test:ios:allTests --mode Release
working-directory: apps/test-app
test-macos:
# Disabling this on main for now, as initializing the template takes a long time and
Expand Down Expand Up @@ -291,7 +291,7 @@ jobs:
- name: Build weak-node-api for all Android architectures
run: pnpm --filter weak-node-api run prebuild:build:android
- name: Build ferric-example for all architectures
run: pnpm run build -- --android
run: pnpm run build --android
working-directory: packages/ferric-example
- name: Run tests (Android)
timeout-minutes: 75
Expand All @@ -313,7 +313,7 @@ jobs:
adb logcat > emulator-logcat.txt 2>&1 &
LOGCAT_PID=$!
# Build, install and run the app
pnpm run test:android:allTests -- --mode Release
pnpm run test:android:allTests --mode Release
# Wait a bit for the sub-process to terminate, before terminating the emulator
sleep 5
# Stop logcat
Expand Down
Loading