Skip to content

Rework documentation - #563

Merged
lisajulia merged 18 commits into
mainfrom
rework-documentation
Sep 9, 2025
Merged

lisajulia merged 18 commits into
mainfrom
rework-documentation

Conversation

@lisajulia

@lisajulia lisajulia commented Sep 4, 2025 •

Copy link
Copy Markdown
Contributor

Look at it here:
https://github.com/cap-java/cds-feature-attachments/tree/rework-documentation

Changes:

@lisajulia
lisajulia force-pushed the rework-documentation branch 3 times, most recently from 7d3fe56 to 74dc59a Compare September 4, 2025 13:45
@lisajulia
lisajulia marked this pull request as draft September 4, 2025 13:45
@lisajulia
lisajulia marked this pull request as draft September 4, 2025 13:45
@lisajulia
lisajulia marked this pull request as draft September 4, 2025 13:45
@lisajulia
lisajulia marked this pull request as draft September 4, 2025 13:45
@lisajulia
lisajulia force-pushed the rework-documentation branch from 74dc59a to 9da5a45 Compare September 4, 2025 13:46
@lisajulia
lisajulia force-pushed the rework-documentation branch from 9da5a45 to 950a666 Compare September 4, 2025 14:38

@maxieckert-sap maxieckert-sap left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more general remark:

  • the documentation uses both, the bookshop sample, as well as the incidents sample app -> let's try to streamline it and use a common sample throughout the docs (i.e. incidents)

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md
lisajulia and others added 2 commits September 9, 2025 08:14
Co-authored-by: René Jeglinsky <rene.jeglinsky@sap.com>
@lisajulia

Copy link
Copy Markdown
Contributor Author

In capire we would avoid using e.g. and i.e. but I didn't change it here. I'll leave it up to you to replace these with "for example" or "that is" or not.

I've replaced these. Thanks!

@lisajulia

Copy link
Copy Markdown
Contributor Author

@renejeglinsky, @eric-pSAP, @maxieckert-sap, @mofterdinger: Can you have yet another look? Thanks!

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md
Comment thread README.md Outdated
Comment thread README.md
Comment thread README.md Outdated
Comment thread storage-targets/cds-feature-attachments-oss/README.md
Comment thread storage-targets/cds-feature-attachments-oss/README.md
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md
@lisajulia
lisajulia force-pushed the rework-documentation branch 2 times, most recently from 60f6b1f to ba5007c Compare September 9, 2025 14:03
@lisajulia
lisajulia force-pushed the rework-documentation branch from ba5007c to be23fff Compare September 9, 2025 14:06
@lisajulia
lisajulia marked this pull request as ready for review September 9, 2025 14:09

@renejeglinsky renejeglinsky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@lisajulia
lisajulia merged commit ce08b97 into main Sep 9, 2025
4 checks passed
@lisajulia
lisajulia deleted the rework-documentation branch September 9, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants