Rework documentation - #563
Merged
Merged
Conversation
lisajulia
force-pushed
the
rework-documentation
branch
3 times, most recently
from
September 4, 2025 13:45
7d3fe56 to
74dc59a
Compare
lisajulia
marked this pull request as draft
September 4, 2025 13:45
lisajulia
marked this pull request as draft
September 4, 2025 13:45
lisajulia
marked this pull request as draft
September 4, 2025 13:45
lisajulia
marked this pull request as draft
September 4, 2025 13:45
lisajulia
force-pushed
the
rework-documentation
branch
from
September 4, 2025 13:46
74dc59a to
9da5a45
Compare
lisajulia
force-pushed
the
rework-documentation
branch
from
September 4, 2025 14:38
9da5a45 to
950a666
Compare
maxieckert-sap
left a comment
There was a problem hiding this comment.
One more general remark:
- the documentation uses both, the bookshop sample, as well as the incidents sample app -> let's try to streamline it and use a common sample throughout the docs (i.e. incidents)
eric-pSAP
reviewed
Sep 5, 2025
eric-pSAP
reviewed
Sep 5, 2025
Co-authored-by: René Jeglinsky <rene.jeglinsky@sap.com>
Contributor
Author
I've replaced these. Thanks! |
Contributor
Author
|
@renejeglinsky, @eric-pSAP, @maxieckert-sap, @mofterdinger: Can you have yet another look? Thanks! |
maxieckert-sap
approved these changes
Sep 9, 2025
eric-pSAP
reviewed
Sep 9, 2025
eric-pSAP
reviewed
Sep 9, 2025
eric-pSAP
reviewed
Sep 9, 2025
eric-pSAP
reviewed
Sep 9, 2025
eric-pSAP
reviewed
Sep 9, 2025
eric-pSAP
reviewed
Sep 9, 2025
eric-pSAP
reviewed
Sep 9, 2025
eric-pSAP
reviewed
Sep 9, 2025
eric-pSAP
reviewed
Sep 9, 2025
eric-pSAP
reviewed
Sep 9, 2025
eric-pSAP
reviewed
Sep 9, 2025
eric-pSAP
reviewed
Sep 9, 2025
eric-pSAP
reviewed
Sep 9, 2025
eric-pSAP
reviewed
Sep 9, 2025
eric-pSAP
reviewed
Sep 9, 2025
lisajulia
force-pushed
the
rework-documentation
branch
2 times, most recently
from
September 9, 2025 14:03
60f6b1f to
ba5007c
Compare
lisajulia
force-pushed
the
rework-documentation
branch
from
September 9, 2025 14:06
ba5007c to
be23fff
Compare
lisajulia
marked this pull request as ready for review
September 9, 2025 14:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Look at it here:
https://github.com/cap-java/cds-feature-attachments/tree/rework-documentation
Changes: