Skip to content

fix: fail in progress tasks on crash - #157

Merged
Akatuoro merged 4 commits into
mainfrom
fix/fail-in-progress-tasks
Oct 2, 2026
Merged

Akatuoro merged 4 commits into
mainfrom
fix/fail-in-progress-tasks

Conversation

@schiwekM

@schiwekM schiwekM commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

On an unstable server, tasks quickly pilled up and then the user got the message that they had concurrent tasks running and the new task could not be submitted.

With this PR:

  • Properly fail tasks on shutdown

HITL flow for concurrent tasks, so a user can stop other tasks when starting a new one -> new pr

Have you...

  • Added relevant entry to the change log?

@schiwekM
schiwekM marked this pull request as ready for review September 28, 2026 15:05
@schiwekM
schiwekM requested review from a team as code owners September 28, 2026 15:05
@schiwekM schiwekM mentioned this pull request Sep 28, 2026
1 task done
@Akatuoro

Copy link
Copy Markdown
Contributor

This does not seem like a fitting solution... even if the server restarts regularly, running tasks will be marked as failed. We should strive to resume tasks after restart. Langchain should be able to do that right?

Akatuoro
Akatuoro previously approved these changes Oct 2, 2026
@Akatuoro
Akatuoro added this pull request to the merge queue Oct 2, 2026
Merged via the queue into main with commit 8fad9d6 Oct 2, 2026
9 checks passed
@Akatuoro
Akatuoro deleted the fix/fail-in-progress-tasks branch October 2, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants