Conversation
Contributor
Control PanelHi, I'm an AI-powered Review Bot that helps you with summarizing and reviewing pull requests.
|
danjoa
reviewed
Oct 2, 2026
danjoa
reviewed
Oct 2, 2026
danjoa
reviewed
Oct 2, 2026
danjoa
requested changes
Oct 2, 2026
danjoa
left a comment
danjoa
left a comment
Member
There was a problem hiding this comment.
Also a full reject, sorry @vkozyura (please don't feel set back by that, I really appreciate your reviews and proposals). Reasons: see comments below, plus: The ports are determined through .env files in each project, and we should stick to these. Choosing the ports as shown would actually bring us in constant conflict: 4004 is the bookshop. 4005 the sidecar.
Co-authored-by: Daniel Hutzel <daniel.hutzel@sap.com>
Co-authored-by: Daniel Hutzel <daniel.hutzel@sap.com>
Co-authored-by: Daniel Hutzel <daniel.hutzel@sap.com>
Co-authored-by: Daniel Hutzel <daniel.hutzel@sap.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related; capire/xtravels#65