Fix crash when rendering quote images with multiline author - #137
Merged
Merged
Conversation
draw.textlength() raises ValueError ("can't measure length of multiline
text") when given text containing newlines. A stored quote author can
contain newline characters, which produced a multiline author string and
crashed the /quote command.
Harden get_text_length() to measure the widest line instead of failing,
and normalize the author to a single line so it renders and centers
cleanly.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RKmj7PMxqNgWnprxf5GfpT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
/quotecommand crashed withValueError: can't measure length of multiline textwhenever a quote's author contained a newline character.PIL's
draw.textlength()refuses any string containing\n. Inquote_image.py, the author line was built directly from the stored author value (f'— {author}'). A stored author can contain newlines (Discord display names allow them, and older stored quotes may carry them), which produced a multiline string and crashedget_text_length()→draw.textlength(), taking down the whole command.Changes
get_text_length()to measure each line and return the widest, so it can never crash on multiline input regardless of source (quote or author).Testing
python -m py_compile cogs/quotes/quote_image.py.Traceback (before fix)
🤖 Generated with Claude Code
Generated by Claude Code