build: mirror rtsp-patterns.json alongside cameras.json - #398
Merged
Merged
Conversation
DATA_MIRROR_DIR copied cameras.json and data-meta.json but not the RTSP guide layer, so the downstream site kept rendering old guides after a guide correction (in 2.27.0, 23 brand guides were stale there, and Digital Watchdog's guide page contradicted its 115 camera pages). Copy data/rtsp-patterns.json too when it exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build tooling only, no data change.
DATA_MIRROR_DIRcopiedcameras.jsonanddata-meta.json, but notdata/rtsp-patterns.json. The site's RTSP guide pages kept the old guides after 2.27.0: 23 of them were stale, and Digital Watchdog's guide still gave the Dahua path while its 115 camera pages said/profile1. The build now copies the guide file too.Tested with
DATA_MIRROR_DIR=<tmp> node scripts/build.js. The mirror directory gets all three files, andrtsp-patterns.jsonis byte-identical todata/. No tracked files change.package.jsonstays at 2.27.0, so merging this won't cut a release.