feat: carry all published relay addresses in securejoin links - #8591
feat: carry all published relay addresses in securejoin links#8591j-g00da wants to merge 1 commit into
Conversation
2027cd2 to
e2d64f9
Compare
Carry all published "secondary" addresses in `r` param of the securejoin URL. Closes: #8590 Signed-off-by: Jagoda 艢l膮zak <jslazak@jslazak.com>
e2d64f9 to
da64e59
Compare
j-g00da
changed the title
| assert msg2.chat == alice.create_chat(bob) | ||
|
|
||
|
|
||
| def test_qr_includes_all_published_transports(acf) -> None: |
There was a problem hiding this comment.
For a test that is not directly testing the implementation by parsing the URL interesting property is that if Alice sets up a profile, adds another relay, make a QR code and then removes the first relay, Bob can still scan the QR code and reach Alice.
EDIT: the code to parse the relays from the QR code is actually missing, so this will fail. This is the main part SecureJoin vc-request-pubkey message (no need to do anything about vc-request from the legacy protocol if it is additional effort) should be sent to all addresses at once.
There was a problem hiding this comment.
As for cross-core test mentioned in #8590, there are existing tests for securejoin, but still possible to make a test copy-pasted from the first half of test_qr_setup_contact with Alice adding multiple relays (this time without removing the first relay) and testing that remote Bob (using old core) can scan the QR code and get in contact with Alice, just to make sure Bob can parse the QR code.
2 participants
Closes: #8590