Skip to content

Refine IsContainFields function #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TingyuHuang wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refine IsContainFields function #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/http.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class Http {
static const std::vector<std::string> passwdFields;
static const std::vector<std::string> sessionFields;

bool IsContainFields(std::string content, std::vector<std::string> fields);
static bool IsContainFields(const std::string &content, const std::vector<std::string> &fields);

std::string method_;
std::string path_;
Expand Down
8 changes: 4 additions & 4 deletions src/http.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ bool Http::IsCredz()
IsContainFields(cookie_, sessionFields);
}

bool Http::IsContainFields(string content, vector<string> fields)
bool Http::IsContainFields(const string &content, const vector<string> &fields)
{
boost::algorithm::to_lower(content);
for (auto &field : fields) {
if (string::npos != content.find(field)) {
auto lower_content = boost::to_lower_copy<string>(content);
for (const auto &field : fields) {
if (string::npos != lower_content.find(field)) {
return true;
}
}
Expand Down