perf: emit non-overridable constants as C static const values - #898
Merged
Conversation
ToddFincannonEI
approved these changes
Aug 27, 2026
ToddFincannonEI
left a comment
Collaborator
There was a problem hiding this comment.
I took only a cursory look at the code to make sure that the input vars check would work for EPS. I won't be able to try it until I do the next update of SDEverywhere in the EPS builder in a couple of weeks. Based on the tests and the opt-in decision, I think this can go forward. Another nice and simple optimization with significant impact!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #896
See issue for details. I left this as an opt-in optimization (enabled via non-public environment variable) since it can have a small effect on model outputs values, but I will probably eventually enable it for En-ROADS since it provides a decent performance improvement.
AI disclosure: I guided Claude Code (Opus 5) to plan and implement the changes, and then I reviewed and refined the changes.