fix: handle cycles when reducing variables - #899
Merged
Conversation
ToddFincannonEI
approved these changes
Aug 27, 2026
ToddFincannonEI
left a comment
ToddFincannonEI
left a comment
Collaborator
There was a problem hiding this comment.
This looks like simple cleanup to me and is well covered by the tests, so let's go ahead with it.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #897
See issue for details. The fix is simple; just return early instead of throwing, which skips any optimization. This case was only likely to come up in practice when using the non-public / opt-in "aggressive" mode, so it should have no impact on existing models with default compilation.
AI disclosure: I guided Claude Code (Opus 5) to plan and implement the changes, and then I reviewed and refined the changes.