fix(testing): recover from lock poisoning in memoized! macro to preve… - #5846
Open
rohanranjan0902 wants to merge 1 commit into
Open
fix(testing): recover from lock poisoning in memoized! macro to preve…#5846rohanranjan0902 wants to merge 1 commit into
rohanranjan0902 wants to merge 1 commit into
Conversation
…nt CI flakes (fixes clockworklabs#5841)
|
Rohan Ranjan Prasad seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR fixes a CI test suite flake (Issue #5841) caused by lock poisoning in
crates/testing/src/sdk.rs.Previously, if a test panicked while compiling a module inside the
memoized!macro, it would poison theMutexholding theMEMOIZEDcompilation cache. Any subsequent tests attempting to access the cache would panic with aPoisonError, causing unrelated tests to fail and masking the original error.This replaces
.lock().unwrap()with.lock().unwrap_or_else(|e| e.into_inner())on the cache mutex. This safely recovers the lock after a panic, allowing unrelated tests to continue compiling and running their own modules instead of failing in cascade.Fixes #5841
API and ABI breaking changes
None. This is strictly a fix for the test harness.
Expected complexity level and risk
1
Trivial change using standard Rust idioms for recovering from test-induced lock poisoning.
Testing
unwrap_or_elsesyntax cleanly handles lock recovery without polluting test suite results.PoisonErrors.