Add claude config - #269
Conversation
Yavor16
left a comment
Yavor16
left a comment
There was a problem hiding this comment.
I see no mention that there must be Jira backlog in the commit description. Add also don't-s section. like don't to relases or edit the version files. something like that
|
|
||
| ## Tech Stack | ||
|
|
||
| - **Go** / go modules (`github.com/cloudfoundry-incubator/multiapps-cli-plugin`) |
There was a problem hiding this comment.
This link is outdated. It still works but update it with the new one
| ## File Upload | ||
|
|
||
| MTAR archives are split into chunks before upload: | ||
|
|
||
| - Default chunk size: **45 MB** — controlled by `MULTIAPPS_UPLOAD_CHUNK_SIZE` | ||
| - Maximum **50 chunks** (`MaxFileChunkCount` in `util/file_splitter.go`) — minimum chunk size is enforced as `ceil(mtar_size_mb / 50)` | ||
| - Chunks upload **in parallel** by default — set `MULTIAPPS_UPLOAD_CHUNKS_SEQUENTIALLY=true` to serialize |
There was a problem hiding this comment.
Why do we have a separate section for file upload and not for any other scenario? Should we just remove it?
| | `clients/mtaclient_v2/` | go-openapi generated MTA REST client (API v2) | | ||
| | `clients/mtaclient/fakes/` | Fake v1 client builder for tests | | ||
| | `clients/mtaclient_v2/fakes/` | Fake v2 client builder for tests | | ||
| | `clients/restclient/` | Lower-level REST client (file upload, operations polling) | |
There was a problem hiding this comment.
clients/baseclient/ and clients/swagger/ are missing. add them also to this list
| 4. **Run tests:** | ||
| ```bash | ||
| go test ./commands/... | ||
| # or all packages: | ||
| go test ./... | ||
| ``` | ||
|
|
||
| 5. **Format:** | ||
| ```bash | ||
| gofmt -w cli clients commands testutil ui util | ||
| ``` | ||
|
|
||
| 6. **Build:** | ||
| ```bash | ||
| go build -ldflags "-X main.Version=$(cat cfg/VERSION)" -o multiapps-plugin . | ||
| ``` | ||
|
|
||
| 7. **Install into CF CLI:** | ||
| ```bash | ||
| cf install-plugin ./multiapps-plugin -f | ||
| ``` |
There was a problem hiding this comment.
These are part of the section for a new command but if the task is not to add a new command then these would be irrelevant. why this section is specific for a new command? can you make it more generic for a new task and not command specific.
| ## REST API Contract | ||
|
|
||
| - **v1** `/api/v1/spaces/{spaceGuid}/` — full operation set | ||
| - **v2** `/api/v2/spaces/{spaceGuid}/` — MTA listing with namespace filtering |
There was a problem hiding this comment.
Why is this section so important to be added?
| ## Controller URL Resolution | ||
|
|
||
| Resolved in this priority order (`util/deploy_service_url_calculator.go`): | ||
|
|
||
| 1. `-u` flag on the command line | ||
| 2. `MULTIAPPS_CONTROLLER_URL` environment variable | ||
| 3. Auto-derived: strips the CF API host up to the first `.` and prepends `deploy-service.` | ||
| (e.g. `https://api.cf.example.com` → `deploy-service.cf.example.com`) |
There was a problem hiding this comment.
Is the resolution so important that must be added here
2 participants
No description provided.