fix: pass the Codecov files input as a comma-separated list - #135
Merged
Conversation
codecov.sh sets IFS=, before splitting CC_FILES, so the newline block scalar from #134 became one --file argument with an embedded newline and uploaded nothing.
amanabiy
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
filesmust be comma-separated, not a newline block scalar.dist/codecov.shsetsIFS=,(line 171) before thefor file in $CC_FILESloop (line 187), so a newline-separated value is never split. #134 shipped the block-scalar form, which produced a single--fileargument with an embedded newline: the CLI loggednot_found_files: ["coverage/lcov.info\ncoverage/clover.xml\n"], thenFound 0 coverage files to reportandError: No coverage reports found, so fork coverage uploaded nothing.Evidence: cloudscape-design/components run 33522194549, both matrix legs, after #134 merged.
Reverified against the real script with
IFS=,: the newline form yields 1 argument, the comma form yields 2. Please keep the comma form.