feat: upload fork pull request coverage to Codecov - #254
Draft
ernst-dev wants to merge 2 commits into
Draft
Conversation
The shared codecov-fork-upload workflow requests pull-requests: read for its pull request resolver step. A called reusable workflow's permissions must be a subset of the caller's, so granting only actions and contents made the call fail workflow validation before any job ran.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Adds a thin
workflow_runwrapper that calls the privileged reusable workflow incloudscape-design/actions, restoring Codecov coverage for fork pull requests. Fork PRs run without secrets, soCODECOV_TOKENis unavailable and the upload cannot happen from the build job.This mirrors the existing
deploy-fork-preview.ymlwrapper in this repository — same filename convention, trigger shape, workflow-levelpermissions, job naming andsecrets: inherit— so the fork-preview and fork-coverage flows now cover the same repositories. Nowith:is passed because the reusable workflow'sartifact-nameinput defaults tocoverage-report.All privileged logic lives in
cloudscape-design/actions; this file is only the rollout unit. It never checks out or executes fork code.Verified for this repo, not assumed
The caller workflow's
name:is exactlyBuild, lint and test, matching this wrapper'sworkflow_run.workflowsentry.workflow_runmatches on workflow name, so a mismatch would silently never fire.coverage/is confirmed as the correct output path:vite.config.unit.mjssetscoverage.enabled: trueand noreportsDirectory, so vitest writes to its default./coverage. Configured reporters are clover, lcov, html and json.Rollout order
cloudscape-design/actions#131has already landed (d3eca61onmain), socodecov-fork-upload.yml@mainresolves and this wrapper has no pending prerequisite. It does not depend oncloudscape-design/actions#132either: that PR only adds an optionalcoverage-artifact-nameinput for matrix callers, and the default this wrapper relies on is unchanged.The upstream workflow uploads to Codecov for real, and runs with
continue-on-error: true, so a failure there can never block a pull request. The attribution risk and the first-run checks are documented in #131; they are not duplicated here.Must never be a required status check
This workflow deliberately does not run on
merge_group(it only triggers onworkflow_runof a pull request build). Adding it as a required status check would deadlock the merge queue.Context: cloudscape-design/actions#131, cloudscape-design/build-tools#78.